hachikuji commented on code in PR #12185:
URL: https://github.com/apache/kafka/pull/12185#discussion_r879659761
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -2195,22 +2193,18 @@ object TestUtils extends Logging {
RequestHeader.parse(envelopeBuffer)
- var requestContext = new RequestContext(envelopeHeader, "1",
InetAddress.getLocalHost,
+ val envelopeContext = new RequestContext(envelopeHeader, "1",
InetAddress.getLocalHost,
KafkaPrincipal.ANONYMOUS, listenerName, SecurityProtocol.PLAINTEXT,
ClientInformation.EMPTY,
fromPrivilegedListener, Optional.of(principalSerde))
- if (shouldSpyRequestContext) {
- requestContext = Mockito.spy(requestContext)
- }
-
new RequestChannel.Request(
processor = 1,
- context = requestContext,
+ context = envelopeContext,
startTimeNanos = startTimeNanos,
memoryPool = MemoryPool.NONE,
buffer = envelopeBuffer,
metrics = requestChannelMetrics,
- envelope = envelope
Review Comment:
Yes, exactly. There should be no envelope if the request itself is
representing one. I think this code might be leftover from the early days when
we were doing the envelope unwrapping in the network code before it reached the
request handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
