hachikuji commented on code in PR #12181:
URL: https://github.com/apache/kafka/pull/12181#discussion_r880748010
##########
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##########
@@ -498,6 +498,23 @@ public UsableBroker next() {
}
}
+ /**
+ * Check if the given broker is active. A broker is active if it is
unfenced,
+ * and not shutting down.
Review Comment:
Yeah, good point about 2). On the other hand, perhaps this is a rarer case.
The scenario requires the broker to stop heartbeating to the controller, but
continue fetching from brokers. So some kind of network partition, for example.
Even then, it is a race condition with receiving the FencedBroker record. Since
we would still have the protection on the controller side, perhaps that is
enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
