[ 
https://issues.apache.org/jira/browse/KAFKA-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542181#comment-17542181
 ] 

Jose Armando Garcia Sancio commented on KAFKA-13884:
----------------------------------------------------

Thanks for working on this [~Jack-Lee] . I think we can do the following on the 
observer replicas:
 # appendAsFollower doesn't call UnifiedLog#flush if the replica is an observer.
 # On a segment roll flush up to the active segment. This should already happen 
if you look at UnifiedLog#roll
 # Flush the segments when the observer shutsdown. This should already happen 
when KafkaRaftClient#close is called since in transitively calls close for 
UnifiedLog, LocalLog, LogSegment, etc.

Looking at the code, I think what we need to implement is 1. What do you think?

> KRaft Obsever are not required to flush on every append
> -------------------------------------------------------
>
>                 Key: KAFKA-13884
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13884
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jose Armando Garcia Sancio
>            Priority: Major
>
> The current implementation of the KRaft Client flushes to disk when observers 
> append to the log. This is not required since observer don't participate in 
> leader election and the advancement of the high-watermark.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to