hachikuji commented on code in PR #12210: URL: https://github.com/apache/kafka/pull/12210#discussion_r884021170
########## tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py: ########## @@ -73,6 +75,7 @@ def min_cluster_size(self): @parametrize(broker_version=str(LATEST_2_8)) @parametrize(broker_version=str(LATEST_3_0)) @parametrize(broker_version=str(LATEST_3_1)) + @parametrize(broker_version=str(LATEST_3_2)) def test_produce_consume(self, broker_version, metadata_quorum=quorum.zk): Review Comment: I wonder if it's useful to continue testing older versions that we have not touched in years. Could we draw the line at 2.4 for example? For older versions, the main thing that seems useful to continue testing is the upgrade/downgrade tests. We don't necessarily have to change this in this patch of course, I'm just curious to hear what people think. cc @ijuma ########## tests/kafkatest/tests/core/upgrade_test.py: ########## @@ -91,6 +94,9 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None): self.wait_until_rejoin() @cluster(num_nodes=6) + @parametrize(from_kafka_version=str(LATEST_3_2), to_message_format_version=None, compression_types=["none"]) Review Comment: Shall we update downgrade_test as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org