divijvaidya commented on PR #12197: URL: https://github.com/apache/kafka/pull/12197#issuecomment-1141344082
> Thanks @divijvaidya for the PR! > > Should we also update this instance https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/AbstractIndex.scala#L110 ? @mimaison I am going to address that code block in a separate PR along with replacement of RandomAccessFile with newer (SeekableByteChannel) APIs. This code block also requires some refactoring since we have code logic which relies on whether a new file was created or not. I will prefer to pick this file separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
