ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r886760998
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##########
@@ -82,7 +107,12 @@ public void process(final Record<KIn, VIn> record) {
final String topic = topicExtractor.extract(key, value,
contextForExtraction);
- collector.send(topic, key, value, record.headers(), timestamp,
keySerializer, valSerializer, partitioner);
+ final int bytesProduced =
+ collector.send(topic, key, value, record.headers(), timestamp,
keySerializer, valSerializer, partitioner);
+
+ // Just use the cached system time to avoid the clock lookup
Review Comment:
Optimization to hopefully bypass any potential concern or risk of
performance regression -- it may be paranoid or an over-optimization at this
point but imo it doesn't hurt to report these metrics at a slightly more
course-grained time interval. Happy to go either way on this however
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
