Author: fmueller
Date: Thu Feb 3 02:26:00 2011
New Revision: 9301
URL: http://svn.slimdevices.com/jive?rev=9301&view=rev
Log:
Bug: 15741
Description: Fix media eject (SD and USB) by allowing iterator to finish - this
closes the directory actively.
Modified:
7.6/trunk/squeezeplay/src/squeezeplay_squeezeos/share/applets/SetupFirmwareUpgrade/SetupFirmwareUpgradeApplet.lua
Modified:
7.6/trunk/squeezeplay/src/squeezeplay_squeezeos/share/applets/SetupFirmwareUpgrade/SetupFirmwareUpgradeApplet.lua
URL:
http://svn.slimdevices.com/jive/7.6/trunk/squeezeplay/src/squeezeplay_squeezeos/share/applets/SetupFirmwareUpgrade/SetupFirmwareUpgradeApplet.lua?rev=9301&r1=9300&r2=9301&view=diff
==============================================================================
---
7.6/trunk/squeezeplay/src/squeezeplay_squeezeos/share/applets/SetupFirmwareUpgrade/SetupFirmwareUpgradeApplet.lua
(original)
+++
7.6/trunk/squeezeplay/src/squeezeplay_squeezeos/share/applets/SetupFirmwareUpgrade/SetupFirmwareUpgradeApplet.lua
Thu Feb 3 02:26:00 2011
@@ -171,7 +171,11 @@
if version or entry == machine .. ".bin" then
log:info('Firmware update detected on ', path)
upgradePresent = true
- break
+-- Bug 15741 - media ejection SD and USB unreliable
+-- Do not use 'break' to end directory iterator early but let it run to the
very end.
+-- Allowing that actively closes the directory so a subsequent 'umount' is
less likely to fail.
+-- (BTW: There is a close() function in lfs 1.5, but not in lfs 1.2 we are
currently using.)
+-- break
end
end
end
_______________________________________________
Jive-checkins mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/jive-checkins
