Author: ayoung
Date: Wed Mar 28 01:50:33 2012
New Revision: 9683
URL: http://svn.slimdevices.com/jive?rev=9683&view=rev
Log:
Fixed bug 17758: Pop up symbols linger too long on the screen
Do not set a duration of 10000 on jive show-brieflies for current song state,
which are used for playlist jump events, just to ensure that the new track
title is pushed to the first line of the display and stays there until a new
playerStatus arrives (which can take quite a long time under some
circumstances). This affected both the duration of the new title on the display
and that of the the Play pop-up icon if the command was invoked via IR. Having
the popup hang around for 10s can be irritating. Given that the player has
control of title change itself, it can set a long duration on just that element
and use the default show-briefly duration for the popup.
Modified:
7.8/trunk/squeezeplay/src/squeezeplay/share/jive/slim/Player.lua
Modified: 7.8/trunk/squeezeplay/src/squeezeplay/share/jive/slim/Player.lua
URL:
http://svn.slimdevices.com/jive/7.8/trunk/squeezeplay/src/squeezeplay/share/jive/slim/Player.lua?rev=9683&r1=9682&r2=9683&view=diff
==============================================================================
--- 7.8/trunk/squeezeplay/src/squeezeplay/share/jive/slim/Player.lua (original)
+++ 7.8/trunk/squeezeplay/src/squeezeplay/share/jive/slim/Player.lua Wed Mar 28
01:50:33 2012
@@ -1383,19 +1383,16 @@
transitionOn = Window.transitionNone
transitionOff = Window.transitionNone
- -- Bug 15815: We use a long default duration to try to
ensure
- -- that this is still up when the new-track
playerstatus eventually arrives
- -- so that we do not flip-flop between old and new
track title.
- -- See also the delays programmed in
Slim::Control::Queries::statusQuery_filter()
- duration = tonumber(display['duration'] or 3000)
-
-- icon-based showBrieflies only appear for IR
if not usingIR then
showMe = false
end
if not isRemote and playMode and playMode == "play" then
- --provide quicker feedback on NP screen that a
new track is playing, other display delay for next local track can be long.
- self.jnt:notify('playerTitleStatus', self,
textValue, duration)
+ -- Provide quicker feedback on NP screen that a
new track is playing,
+ -- other display delay for next local track can
be long.
+ -- Bug 17758: force long duration on title so
that we do not get oscillation;
+ -- it will get updated with new playerStatus.
+ self.jnt:notify('playerTitleStatus', self,
textValue, 10000)
end
elseif type == 'mixed' or type == 'popupalbum' then
s = self.mixedPopup
_______________________________________________
Jive-checkins mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/jive-checkins
