sebb 2004/09/30 10:59:13
Modified: src/core/org/apache/jmeter/reporters/gui Tag: rel-2_0
ResultSaverGui.java
src/core/org/apache/jmeter/resources Tag: rel-2_0
messages.properties
src/core/org/apache/jmeter/reporters Tag: rel-2_0
ResultSaver.java
Log:
Result Saver - optionally save failed results only
Revision Changes Path
No revision
No revision
1.4.2.1 +14 -4
jakarta-jmeter/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
Index: ResultSaverGui.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java,v
retrieving revision 1.4
retrieving revision 1.4.2.1
diff -u -r1.4 -r1.4.2.1
--- ResultSaverGui.java 5 Mar 2004 01:34:53 -0000 1.4
+++ ResultSaverGui.java 30 Sep 2004 17:59:13 -0000 1.4.2.1
@@ -21,6 +21,7 @@
import java.awt.BorderLayout;
import javax.swing.Box;
+import javax.swing.JCheckBox;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JTextField;
@@ -29,6 +30,7 @@
import org.apache.jmeter.processor.gui.AbstractPostProcessorGui;
import org.apache.jmeter.testelement.TestElement;
import org.apache.jmeter.util.JMeterUtils;
+import org.apache.jorphan.util.JOrphanUtils;
/**
* Create a ResultSaver test element, which saves the sample information
@@ -40,6 +42,7 @@
{
private JTextField filename;
+ private JCheckBox errorsOnly;
public ResultSaverGui()
{
@@ -52,7 +55,7 @@
*/
public String getLabelResource()
{
- return "resultsaver_title";
+ return "resultsaver_title"; // $NON-NLS-1$
}
/**
@@ -62,6 +65,7 @@
{
super.configure(el);
filename.setText(el.getPropertyAsString(ResultSaver.FILENAME));
+ errorsOnly.setSelected(el.getPropertyAsBoolean(ResultSaver.ERRORS_ONLY));
}
/**
@@ -82,6 +86,8 @@
{
super.configureTestElement(te);
te.setProperty(ResultSaver.FILENAME, filename.getText());
+ te.setProperty(ResultSaver.ERRORS_ONLY,
+ JOrphanUtils.booleanToString(errorsOnly.isSelected()));
}
private void init()
@@ -91,13 +97,17 @@
Box box = Box.createVerticalBox();
box.add(makeTitlePanel());
box.add(createFilenamePanel());
+ errorsOnly =
+ new JCheckBox(JMeterUtils.getResString("resultsaver_errors"));
// $NON-NLS-1$
+ box.add(errorsOnly);
add(box,BorderLayout.NORTH);
// add(makeTitlePanel(),BorderLayout.NORTH);
}
private JPanel createFilenamePanel()//TODO ought to be a FileChooser ...
{
- JLabel label = new
JLabel(JMeterUtils.getResString("resultsaver_prefix"));
+ JLabel label =
+ new JLabel(JMeterUtils.getResString("resultsaver_prefix")); //
$NON-NLS-1$
filename = new JTextField(10);
filename.setName(ResultSaver.FILENAME);
No revision
No revision
1.106.2.8 +1 -0
jakarta-jmeter/src/core/org/apache/jmeter/resources/messages.properties
Index: messages.properties
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/resources/messages.properties,v
retrieving revision 1.106.2.7
retrieving revision 1.106.2.8
diff -u -r1.106.2.7 -r1.106.2.8
--- messages.properties 9 Jul 2004 23:25:03 -0000 1.106.2.7
+++ messages.properties 30 Sep 2004 17:59:13 -0000 1.106.2.8
@@ -365,6 +365,7 @@
request_data=Request Data
restart=Restart
resultaction_title=Result Status Action Handler
+resultsaver_errors=Save Failed Responses only
resultsaver_prefix=Filename prefix\:
resultsaver_title=Save Responses to a file
root=Root
No revision
No revision
1.4.2.4 +11 -3
jakarta-jmeter/src/core/org/apache/jmeter/reporters/ResultSaver.java
Index: ResultSaver.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/reporters/ResultSaver.java,v
retrieving revision 1.4.2.3
retrieving revision 1.4.2.4
diff -u -r1.4.2.3 -r1.4.2.4
--- ResultSaver.java 12 Jun 2004 18:32:05 -0000 1.4.2.3
+++ ResultSaver.java 30 Sep 2004 17:59:13 -0000 1.4.2.4
@@ -51,7 +51,8 @@
// File name sequence number
private static long sequenceNumber = 0;
- public static final String FILENAME = "FileSaver.filename";
+ public static final String FILENAME = "FileSaver.filename"; // $NON-NLS-1$
+ public static final String ERRORS_ONLY = "FileSaver.errorsonly"; // $NON-NLS-1$
private static synchronized long nextNumber(){
return ++sequenceNumber;
@@ -109,6 +110,9 @@
* @param s SampleResult to save
*/
private void saveSample(SampleResult s) {
+ // Should we save successful samples?
+ if (s.isSuccessful() && getErrorsOnly()) return;
+
nextNumber();
String fileName=makeFileName(s.getContentType());
log.debug("Saving "+s.getSampleLabel()+" in "+fileName);
@@ -171,5 +175,9 @@
private String getFilename()
{
return getPropertyAsString(FILENAME);
+ }
+ private boolean getErrorsOnly()
+ {
+ return getPropertyAsBoolean(ERRORS_ONLY);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
