Author: sebb
Date: Sat Nov 12 17:37:07 2005
New Revision: 332870

URL: http://svn.apache.org/viewcvs?rev=332870&view=rev
Log:
Fix incorrect null check

Modified:
    
jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/XMLDefaultMutableTreeNode.java

Modified: 
jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/XMLDefaultMutableTreeNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/XMLDefaultMutableTreeNode.java?rev=332870&r1=332869&r2=332870&view=diff
==============================================================================
--- 
jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/XMLDefaultMutableTreeNode.java
 (original)
+++ 
jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/XMLDefaultMutableTreeNode.java
 Sat Nov 12 17:37:07 2005
@@ -141,7 +141,7 @@
                NamedNodeMap nm = node.getAttributes();
                for (int i = 0; i < nm.getLength(); i++) {
                        Attr nmNode = (Attr) nm.item(i);
-                       String value = nmNode.getName() + " = \"" + 
nmNode.getValue() + "\"";
+                       String value = nmNode.getName() + " = \"" + 
nmNode.getValue() + "\""; // $NON-NLS-1$ $NON-NLS-2$
                        XMLDefaultMutableTreeNode attributeNode = new 
XMLDefaultMutableTreeNode(value, nmNode);
                        mTreeNode.add(attributeNode);
 
@@ -157,8 +157,8 @@
         */
        private void initCommentNode(Comment node, DefaultMutableTreeNode 
mTreeNode) throws SAXException {
                String data = node.getData();
-               if (data != null || data.length() > 0) {
-                       String value = "<!--" + node.getData() + "-->";
+               if (data != null && data.length() > 0) {
+                       String value = "<!--" + node.getData() + "-->"; // 
$NON-NLS-1$ $NON-NLS-2$
                        XMLDefaultMutableTreeNode commentNode = new 
XMLDefaultMutableTreeNode(value, node);
                        mTreeNode.add(commentNode);
                }
@@ -173,8 +173,8 @@
         */
        private void initCDATASectionNode(CDATASection node, 
DefaultMutableTreeNode mTreeNode) throws SAXException {
                String data = node.getData();
-               if (data != null || data.length() > 0) {
-                       String value = "<!-[CDATA" + node.getData() + "]]>";
+               if (data != null && data.length() > 0) {
+                       String value = "<!-[CDATA" + node.getData() + "]]>"; // 
$NON-NLS-1$ $NON-NLS-2$
                        XMLDefaultMutableTreeNode commentNode = new 
XMLDefaultMutableTreeNode(value, node);
                        mTreeNode.add(commentNode);
                }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to