On 11/06/06, Kumara Subramanya <[EMAIL PROTECTED]> wrote:
The stuff has no external dependecies.
What about the JMX libraries? These are not in my JDK 1.4.
The patch should perfectly work under jdk1.4 as per my knowledge.
I found a call to new PrintWriter(String) which is @since 1.5
Easy to fix, but I don't believe the code should be writing files
anyway, that should be left to the existing code.
I think the JMXSampleResult class should be removed; it's just going
to complicate the JTL files.
I don't understand how the visualiser is supposed to work. Does it do
anything other than write to the result file? If not, why do you need
a different visualiser?
To allow use in non-GUI tests, it's important that the GUI elements
only do processing which is related to the GUI.
Have a look a AssertionVisualizer for an example of a simple visualiser.
All it does is implement the add(SampleResult) method. All the code to
write samples to the JTL files is handled by existing JMeter classes.
The visualiser only updates the GUI; it is not involved at all in
non-GUI tests.
I forgot to delete the dist and syn directories when i created the
jar. Sorry for that.
There were no such directories in the zip/jar file, only
plugin
plugin/jmx etc
As per licence is concerned would it be cool if I just copy paste the
apache licence statement into each source files ?.
I need to check that. We may need a CLA as well, as there is a fair
amount of code involved.
Let me know.
I think it will be useful code, but the visualiser area needs a bit of
work to fit in better with the existing JMeter design.
Also, there seems to be a problem with the Sampler GUI. When clicking
on the "Add MBean" button, I get the following message in the console:
java.lang.Error: Do not use org.apache.jmeter.protocol.jmx.control.gui.MBeanTree
.add() use org.apache.jmeter.protocol.jmx.control.gui.MBeanTree.getContentPane()
.add() instead
at javax.swing.JDialog.createRootPaneException(JDialog.java:536)
at javax.swing.JDialog.addImpl(JDialog.java:562)
at java.awt.Container.add(Container.java:307)
at org.apache.jmeter.protocol.jmx.control.gui.MBeanTree.initgui(MBeanTre
e.java:89)
[...]
Try running the code in non-GUI and client-server mode. This is a good
way of finding out if the code is in the right place...
S
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
