DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42018>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42018





------- Additional Comments From [EMAIL PROTECTED]  2007-04-24 23:49 -------
Created an attachment (id=20035)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20035&action=view)
set auto-commit configuration parameter at the same level as pool-controller

I've checked this and you are right. There is a bug on the
DataSourceElement.java . The code tries to se the "auto-commit" attribute as
part of pool-controller but auto-commit doesn't belong to pool-controller it
should be a sibling of pool-controller. This becomes clear taking a look to the
excalibur-datasource-1.1.1.jar source code ResourceLimitingJdbcDataSource.java
, more precisely the lines
*** final Configuration controller = configuration.getChild( "pool-controller"
);

*** final boolean autoCommit = configuration.getChild( "auto-commit"
).getValueAsBoolean( true );

Looking at those lines is evident that pool-controller and auto-commit are
siblings and auto-commit shouldn't be added as a child of pool-controller

I'm providing a patch attached that solves the issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to