Author: sebb
Date: Mon Aug 20 05:34:18 2007
New Revision: 567668
URL: http://svn.apache.org/viewvc?rev=567668&view=rev
Log:
Bug 39792 - ClientJMeter synchronisation needed
Modified:
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java
jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
Modified:
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java?rev=567668&r1=567667&r2=567668&view=diff
==============================================================================
---
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java
(original)
+++
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java
Mon Aug 20 05:34:18 2007
@@ -108,16 +108,22 @@
public void run() {
log.info("running clientengine run method");
testListeners = new SearchByClass(TestListener.class);
- getTestTree().traverse(testListeners);
- sampleListeners = new ConvertListeners();
-
- // TODO this is a temporary fix - see bug 23487
- try {
- getTestTree().traverse(sampleListeners);
- } catch (IndexOutOfBoundsException e) {
- log.warn("Error replacing sample listeners", e);
+ HashTree testTree = getTestTree();
+ // TODO see bug 39792; should not do any harm to synch the
code here
+ // @see http://issues.apache.org/bugzilla/show_bug.cgi?id=39792
+ synchronized(testTree) {
+ testTree.traverse(testListeners);
+ sampleListeners = new ConvertListeners();
+
+ // TODO this is a temporary fix - see bug 23487
+ // @see
http://issues.apache.org/bugzilla/show_bug.cgi?id=23487
+ try { // probably no longer needed, now that the code
is synchronised
+ testTree.traverse(sampleListeners);
+ } catch (IndexOutOfBoundsException e) {
+ log.warn("Error replacing sample listeners", e);
+ }
}
-
+
try {
JMeterContextService.startTest();
remote.setHost(host);
Modified: jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml?rev=567668&r1=567667&r2=567668&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml (original)
+++ jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml Mon Aug 20 05:34:18 2007
@@ -43,6 +43,7 @@
<li>Bug 42919 - Failure Message blank in CSV output [now records first
non-blank message]</li>
<li>Add link to Extending JMeter PDF</li>
<li>Allow for quoted charset in Content-Type parsing</li>
+<li>Bug 39792 - ClientJMeter synchronisation needed</li>
</ul>
<h4>Improvements since 2.3RC3</h4>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
