https://issues.apache.org/bugzilla/show_bug.cgi?id=44600
--- Comment #3 from Sebb <[EMAIL PROTECTED]> 2008-03-13 15:22:22 PST --- (In reply to comment #2) > (In reply to comment #1) > > 2 public createTestSample() methods are deleted by the patch. > > I removed them because I didn't find any callers, but I'll put them back since > you prefer it. Methods cannot be arbitrarily removed. > > Access to the static fields reference...Clock needs to be synchronized - or > > the > > fields need to be final. > > Which would you prefer? > Final is safer and likely cheaper. > > Also, the code requires Java 1.5; JMeter is currently targeted at 1.4, but > > this > > may change. > > Would you prefer a patch that's conditional on the JVM version? > Depends how convoluted it becomes. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
