Author: sebb
Date: Wed Mar 19 20:24:13 2008
New Revision: 639132
URL: http://svn.apache.org/viewvc?rev=639132&view=rev
Log:
Bug 44575 - Result Saver can now save only successful results
[Oops - should have been included in r639127]
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultSaver.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultSaver.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultSaver.java?rev=639132&r1=639131&r2=639132&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultSaver.java
(original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultSaver.java
Wed Mar 19 20:24:13 2008
@@ -34,12 +34,13 @@
import org.apache.log.Logger;
/**
- * Save Result responseData to a set of files TODO - perhaps save other items
- * such as headers?
+ * Save Result responseData to a set of files
+ *
*
* This is mainly intended for validation tests
*
*/
+// TODO - perhaps save other items such as headers?
public class ResultSaver extends AbstractTestElement implements Serializable,
SampleListener, Clearable {
private static final Logger log = LoggingManager.getLoggerForClass();
@@ -50,7 +51,9 @@
public static final String ERRORS_ONLY = "FileSaver.errorsonly"; //
$NON-NLS-1$
- private static synchronized long nextNumber() {
+ public static final String SUCCESS_ONLY = "FileSaver.successonly"; //
$NON-NLS-1$
+
+ private static synchronized long nextNumber() {
return ++sequenceNumber;
}
@@ -120,9 +123,16 @@
* SampleResult to save
*/
private void saveSample(SampleResult s) {
- // Should we save successful samples?
- if (s.isSuccessful() && getErrorsOnly())
- return;
+ // Should we save the sample?
+ if (s.isSuccessful()){
+ if (getErrorsOnly()){
+ return;
+ }
+ } else {
+ if (getSuccessOnly()){
+ return;
+ }
+ }
nextNumber();
String fileName = makeFileName(s.getContentType());
@@ -188,5 +198,9 @@
private boolean getErrorsOnly() {
return getPropertyAsBoolean(ERRORS_ONLY);
}
+
+ private boolean getSuccessOnly() {
+ return getPropertyAsBoolean(SUCCESS_ONLY);
+ }
}
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java?rev=639132&r1=639131&r2=639132&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
(original)
+++
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
Wed Mar 19 20:24:13 2008
@@ -43,6 +43,8 @@
private JCheckBox errorsOnly;
+ private JCheckBox successOnly;
+
public ResultSaverGui() {
super();
init();
@@ -62,15 +64,16 @@
super.configure(el);
filename.setText(el.getPropertyAsString(ResultSaver.FILENAME));
errorsOnly.setSelected(el.getPropertyAsBoolean(ResultSaver.ERRORS_ONLY));
+
successOnly.setSelected(el.getPropertyAsBoolean(ResultSaver.SUCCESS_ONLY));
}
/**
* @see org.apache.jmeter.gui.JMeterGUIComponent#createTestElement()
*/
public TestElement createTestElement() {
- ResultSaver ResultSaver = new ResultSaver();
- modifyTestElement(ResultSaver);
- return ResultSaver;
+ ResultSaver resultSaver = new ResultSaver();
+ modifyTestElement(resultSaver);
+ return resultSaver;
}
/**
@@ -82,6 +85,7 @@
super.configureTestElement(te);
te.setProperty(ResultSaver.FILENAME, filename.getText());
te.setProperty(ResultSaver.ERRORS_ONLY,
errorsOnly.isSelected());
+ te.setProperty(ResultSaver.SUCCESS_ONLY, successOnly.isSelected());
}
/**
@@ -92,6 +96,7 @@
filename.setText(""); //$NON-NLS-1$
errorsOnly.setSelected(false);
+ successOnly.setSelected(false);
}
private void init() {
@@ -102,6 +107,8 @@
box.add(createFilenamePanel());
errorsOnly = new
JCheckBox(JMeterUtils.getResString("resultsaver_errors")); // $NON-NLS-1$
box.add(errorsOnly);
+ successOnly = new
JCheckBox(JMeterUtils.getResString("resultsaver_success")); // $NON-NLS-1$
+ box.add(successOnly);
add(box, BorderLayout.NORTH);
// add(makeTitlePanel(),BorderLayout.NORTH);
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties?rev=639132&r1=639131&r2=639132&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
(original)
+++
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
Wed Mar 19 20:24:13 2008
@@ -613,6 +613,7 @@
resultaction_title=Result Status Action Handler
resultsaver_errors=Save Failed Responses only
resultsaver_prefix=Filename prefix\:
+resultsaver_success=Save Successful Responses only
resultsaver_title=Save Responses to a file
retobj=Return object
reuseconnection=Re-use connection
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
