Author: sebb
Date: Mon Sep 22 12:44:01 2008
New Revision: 697963

URL: http://svn.apache.org/viewvc?rev=697963&view=rev
Log:
Bug 45831 - WS Sampler reports incorrect throughput if SOAP packet creation 
fails

Modified:
    
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java
    jakarta/jmeter/trunk/xdocs/changes.xml

Modified: 
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java?rev=697963&r1=697962&r2=697963&view=diff
==============================================================================
--- 
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java
 (original)
+++ 
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java
 Mon Sep 22 12:44:01 2008
@@ -578,6 +578,19 @@
             } else {
                 throw new RuntimeException(exception);
             }
+        } finally {
+            // Make sure the sample start time and sample end time are 
recorded 
+            // in order not to confuse the statistics calculation methods: if 
+            //  an error occurs and an exception is thrown it is possible that
+            // the result.sampleStart() or result.sampleEnd() won't be called  
+            if (result.getStartTime() == 0)
+            {
+                result.sampleStart();
+            }
+            if (result.getEndTime() == 0)
+            {
+                result.sampleEnd();
+            }
         }
         return result;
     }

Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=697963&r1=697962&r2=697963&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Mon Sep 22 12:44:01 2008
@@ -107,6 +107,7 @@
 "Counter" is now shown as a Configuration element.
 </li>
 <li>HTTPSamplers can now use variables in POSTed file names</li>
+<li>Bug 45831 - WS Sampler reports incorrect throughput if SOAP packet 
creation fails</li>
 </ul>
 
 <h3>Improvements</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to