https://issues.apache.org/bugzilla/show_bug.cgi?id=48749

Sebb <s...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Sebb <s...@apache.org> 2010-02-23 23:29:09 UTC ---
Thanks very much!

The code has been applied:

URL: http://svn.apache.org/viewvc?rev=915587&view=rev
Log:
Bug 48749 - Allowing custom Thread Groups

Added:
  
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java
  (with props)
  
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java
  (with props)
Modified:
  
jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java
  
jakarta/jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/control/gui/TestPlanGui.java
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/ConvertListeners.java
  
jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
  
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestPlan.java
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java
  
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/gui/ThreadGroupGui.java
  
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
  
jakarta/jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java
   jakarta/jmeter/trunk/xdocs/changes.xml

There were a few changes needed:
- AbstractThreadGroupGui.configureTestElement() needed to call
super.configureTestElement()
- Constructors should not call overridable methods; changed init() and added
initGui() to AbstractThreadGroupGui
- patch included a change to TCPSampler which had already been made (and was
irrelevant)
- no need to patch JMeterVersion

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org

Reply via email to