I just checked in some code which makes the menu checkboxes and
radiobuttons work properly. In addition, they now are consistent with the
settings as set by the preferences dialog box.
 - the menu checkbox state is updated to reflect the current settings
   this did not work correctly in the past if the settings were changed
   via the preferences dialog box
 - the menu radio buttons for display style now are updated to accurately
   reflect the current settings
 - modifications made in the preferences dialog box are saved only if you
   hit OK
 - hitting cancel does not undo changes which were made to the settings
   ... but it never did.

Miguel

> I am not sure how Jmol was behaving in the past... but I imagine this
> design handy:
>
> 1. the preferences are the boot settings... i.e. the values the several
> rendering options when Jmol is started...
Yes

> 2. we should define a list of options that the users is likely to change
> within one Jmol session. These should have menu items, the others not...
If we came up with a list I think it would be good.
I personally think that the layout could/should be improved.
I would like to clean up the Preferences Dialog and then use it.

> The option values toggled with the menu do not alter the preference
> settings,  which only indicate the startup values
I think it is hard to do this and make the UI consistent.
It is important that the user have visual feedback and see the changes
that are being made while settings are being modified in the
PreferencesDialog.
Once the PreferencesDialog is open the user can switch focus back to the
menus and change the settings.
I suppose it would be possible to have the display rendering change to
reflect which window has the focus. If the preferences dialog has the
focus then the molecule is rendered according to the Preferneces settings.

The behavior of the code I just checked-in is not perfect. But I think it
is significantly better than the previous behavior. Try it out and let me
know what you think.

>
> Not sure if I make myself perfectly clear... but anyway, here is a
> second try:
>
> 1. For labeling, shading, etc, both menu and preferences exist...
>     The preferences define the boot settings and the initial menu
> settings... In the Jmol session itself the menu settings do not
> change the boot  setting, but change only the current working
> settings... Changing the preferences changes the boot settings and
> the current working settings.
> 2. antialiasing, etc only occur in the preference dialog and determine
> both
>     the boot settings and the current working settings...
>
> Did this help?
Yep!





-------------------------------------------------------
This SF.net email is sponsored by: Microsoft Visual Studio.NET 
comprehensive development tool, built to increase your 
productivity. Try a free online hosted session at:
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr0003en
_______________________________________________
Jmol-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to