Miguel wrote:


This problem is solved in my opinion.


Q: Do you mean 'solved in bob200603' or 'solved in trunk' ?


bob200603


Tell me if you see something you
don't like, but as far as I'm concerned, it's done.


My recollection is that at one point (before you were fired :-) you said
that you thought that perspectiveDepth could be handled in a better/more
elegant/simple way. I am wondering if you found this.

see bob200603


It has been a long time since I looked at the code ... either yours or
mine. That is why I am asking for guidance.

see bob200603

Sorry, what I'm trying to say is that first check the applet functionality and see if you like it. Let that answer your question, "Did Bob solve the problem?" Then look at the code to see how it was done. It is done. Problem solved. Including with that internal rotation/spinning and integration of rotation and spinning.

Caveate: Tim Driscoll just pointed out to me that my implemenation of rotation in 10.x requires integers, not decimals. I guess that happened when I integrated spin and rotation. Is there really a use for FRACTIONAL degree rotation? Is it possible that we could accept a decimal here and integerize it? Doesn't really matter to me, but it would one line in Eval to make it an integer, and significantly more to allow actual decimals.

Bob




Have you played with it on the bob200603 prototype and found it not
working?


I have not looked at it. That is why I am asking.


Please do.


The following commands will be useful:

set windowcentered off
set picking center

then load 1crn.pdb, zoom WAY in, pick an atom close to the camera,
rotate 180 to bring the back end of the model into the camera. Then pick
that one and spin again. Iterate. Tell me when you break the camera.

The very slight jiggle that you see when you click the new atom is the
perspective lens focusing on that atom and distorting the bonds around
it. Very subtle. Not a bad effect, in my opinion, in that has a nice
confirming feel to it.

If you want to fix something, take a look at:

set picking rotate

then start clicking on atoms. There's a slight drift there that I can't
remember if I ever figured out. I guess not; it's still there.


Right now I would rather not try to fix or change anything associated with
transforms.

Right now all I am trying to do is think through the implications of
introducing the following point hierarchy.

javax.vecmath.Point3f
  org.jmol.vecmath.Point3fi
    org.jmol.viewer.Atom

This is going to force some changes to the TransformManager, so I wanted
to know what the current status is from your perspective.

I see. OK. I don't see it as a major issue. The screen points have to be updated every rotation, so who cares if they are stored separately or not? I don't see that it makes any difference at all in terms of camera distance.

I guess my answer is that all I did with perspective depth/camera distance is to create a Point3f perspectiveOffset, which combines xTranslation and yTranslation with the "camera distance" to control the full 3D "camera position" in one nice little package. perspectiveOffset.z, then, is the secret to making "set picking center" work properly when "set windowCentered false". But perspectiveOffset.z = 0 generally.

I guess, more than anything, I would ask that you NOT do this. It is has the potential to cause either you or me or both of us immense headaches as you or I or we integrate chunks of code from bob200603 into the trunk.

Couldn't you wait to do this until after that is done? There was that list....

Bob

--

Robert M. Hanson, [EMAIL PROTECTED], 507-646-3107
Professor of Chemistry, St. Olaf College
1520 St. Olaf Ave., Northfield, MN 55057
mailto:[EMAIL PROTECTED]
http://www.stolaf.edu/people/hansonr

"Imagination is more important than knowledge."  - Albert Einstein


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to