Welcome, Piero Canepa, our newest Jmol developer!
Piero is at the University of Kent (physics, right?) working on a Crystal0X
file reader (http://www.crystal.unito.it/). The interesting thing about this
reader is that it has 2D and 1D periodicity as well as standard 3D
periodicity. Piero and I have been working on this for a few weeks, and it
is looking very good now. Still a few capabilities to include, still
testing. Not "ready for release" to users quite yet, perhaps.
Piero, as you add capabilities, just add some comments at the top of the
file. I'll get automatic messages that indicate you have changed files, but
it's still nice if you send messages to that effect anyway at
[email protected] . Please start using "Jmol Developers"
<[email protected]> for communication with me on this so
that other developers can chime in as need be. A few conventions:
** Please, if you are using Eclipse, do not use CTRL-S-F --- that reformats
the entire file and makes it hard to see what changes are there. What I do
is to highlight sections of code and then use CTRL-S-N.
** Please use standard Java conventions for variable names. That means
starting with lower case and no underscores:
float[] irFrequencies ....
not
float[] IRFrequencies ....
and not
float[] ir_frequencies ...
for example. It doesn't matter so much, but just letting you know that I
will go in and fix those if you don't, and then you will have to
resynchronize!
** Always check for updates before you check code back in. I'll try to stay
out of your way, but if I see a bug, I may go ahead and fix it myself. I'll
try to just tell you it is there.
** Anything else you see there that needs fixing, do tell us!
** We make releases periodically. If new features are added, those are
indicated in viewer.jmol.properties. Mostly don't add information there if
it is just a simple change in code in a reader, at least for now; but later
if we make bug fixes, they are all indicated there.
Looking forward to working with you,
Bob
On Fri, Feb 26, 2010 at 11:02 AM, P.Canepa <[email protected]> wrote:
> ok
> It would be nice I have an acount for sourceforge! My username is
> pierocanepa
>
> --
> Pieremanuele Canepa
> Room 104
> Functional Material Group
> School of Physical Sciences, Ingram Building,
> University of Kent, Canterbury, Kent,
> CT2 7NH
> United Kingdom
>
> e-mail: [email protected]
> mobile: +44 (0) 7772-9756456
> -----------------------------------------------------------
> ________________________________________
> From: Robert Hanson [[email protected]]
> Sent: Friday, February 26, 2010 4:53 PM
> To: P.Canepa
> Subject: Re: Still Crystal
>
> Piero,
>
> Time to make you a Jmol developer. Would you like to do that? For that you
> need a SourceForge account. It would be with the understanding that you
> would restrict your changes to this reader (at least for now). OK?
>
> Bob
>
>
>
>
--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
1520 St. Olaf Ave.
Northfield, MN 55057
http://www.stolaf.edu/people/hansonr
phone: 507-786-3107
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers