I just did a mega-upgrade of file readers. Every one is modified. You should
synchronize if you are doing any active development.
Be on the look-out for problems. Basically what I did was to make the
initializing, line reading, and finalizing much cleaner and clearer. Readers
no longer set their own "fileType" variable -- this is done in Resolver. And
the main loop for reading lines is now local to AtomSetCollectionReader. The
three methods now in individual readers are:
initializeReader()
checkLine()
finalizeReader()
which are all called by
AtomSetCollectionReader.readAtomSetCollection(BufferedReader reader)
The JUnit test passes, so there may not be any problem. One thing I could
not find were Crystal Maker "cmdf" files, and as part of this I am upgrading
ShelxReader, which includes that.
Bob
--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
1520 St. Olaf Ave.
Northfield, MN 55057
http://www.stolaf.edu/people/hansonr
phone: 507-786-3107
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers
