On Wed, 26 Jul 2023 10:50:09 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Specifically noticed on linux-aarch64, detection of port clashes by > LocateRegistry.createRegistry(port) appears "racy". > > Predictable port clashes can be avoided, tests that are likely to run at the > same time should not choose the same port. > > Why now? The RMI related parts are obviously fairly stable these days, as > are the tests themselves. > Our OS version/host mix for testing may have changed. The problems I looked > into were on ol8-aarch64. > > It doesn't seem necessary to add complexities to the tests, or change > LocateRegistry much at this point, when a simple change to the tests can > avoid asking for so many port clashes. > > > > test/jdk/javax/management/remote/mandatory/passwordAuthenticator/RMIPasswdAuthTest.java: > int port = 5800; // 5801 to 5820 > test/jdk/javax/management/remote/mandatory/passwordAuthenticator/RMIAltAuthTest.java: > int port = 5800; // 5821 to 5840 > test/jdk/javax/management/remote/mandatory/socketFactories/RMISocketFactoriesTest.java: > int port = 5800; // 5841 to 5860 > test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java: > int port = 5800; // 5861 to 5880 > test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation2Test.java: > int port = 5800; // 5881 to 5900 > test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation3Test.java: > int port = 5800; // 5901 to 5920 This pull request has now been integrated. Changeset: 169b6e3c Author: Kevin Walls <kev...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/169b6e3cff8f9e0e09cdd5145c2dfe73a88519d1 Stats: 17 lines in 6 files changed: 0 ins; 0 del; 17 mod 8313174: Create fewer predictable port clashes in management tests Reviewed-by: cjplummer, amenkov ------------- PR: https://git.openjdk.org/jdk/pull/15039
