On Tue, 8 Aug 2023 23:04:43 GMT, Kimura Yukihiro <d...@openjdk.org> wrote:
>> I would like to fix this issue >> because the svc jtreg test does not pass on localized Windows platform. >> Testing: >> all serviceability area tests (jdk_svc group). >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge master > - 8313854: Some tests in serviceability area fail on localized Windows > platform > - 8313854: Some tests in serviceability area fail on localized Windows > platform test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 162: > 160: ProcessBuilder pb = new > ProcessBuilder(launcher.getCommand()); > 161: pb.command().add("-J-Duser.language=en"); > 162: pb.command().add("-J-Duser.country=US"); How about a comment: /* Needed so we can properly parse the "Welcome to JShell" output. */ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15172#discussion_r1287776326