On Thu, 5 Oct 2023 18:21:06 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Updated test to use createTesJvm. >> Removed internal timeout to not fail when Xcomp is used and also to get more >> info if the test times out., >> >> Tested by running tier1, hs-tier5 and executing test with various VM flags. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > simplifed usage, removed classpath adding. Looks good to me. Thanks, Serguei test/jdk/sun/management/jmxremote/bootstrap/CustomLauncherTest.java line 100: > 98: ProcessBuilder client = ProcessTools.createJavaProcessBuilder( > 99: "-cp", > 100: Utils.TEST_CLASS_PATH, Just a question: Is the `-cp` options added by the `ProcessTools.createTestJvm()`? ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16048#pullrequestreview-1662878526 PR Review Comment: https://git.openjdk.org/jdk/pull/16048#discussion_r1349370651
