On Thu, 21 Mar 2024 15:06:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments > > test/jdk/java/util/zip/ZipFile/ZeroDate.java line 95: > >> 93: >> 94: // ensure that the archive is still readable, and the date is >> 1979-11-30 >> 95: Path path = Utils.createTempFile("out", ".zip"); > > So it looks like the test library has this utility method which allows to > create temporary files within the jtreg scratch directory. Perhaps we should > use it then. Having said that, is there a reason why one test method in this > test now uses `Files.createTempFile(...)` and this other test method uses > `Utils.createTempFile(...)`? Yes, you are right. We don't need explicit deletion for these files by using this util method, Utils.createTempFile. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1534290137