On Thu, 16 May 2024 10:37:36 GMT, Kevin Walls <[email protected]> wrote:
>> This shows that when SubjectDelegation was not used, a null-filled array of
>> the same length as the two other arrays was expected before (in previous
>> versions of the JDK where SubjectDelegation was supported, but in the case
>> where it wasn't used).
>> I am not suggesting to document the length requirement. The length
>> requirement was enforced before and undocumented. I'm just suggesting that
>> we allow null and null-filled but don't allow something (null filled array
>> of wrong length) that would have been rejeceted in previous JDK versions. I
>> would also suggest to check the length before the content - in case an array
>> is supplied.
>
> Yes, completely understand. I just don't think it has any benefit.
Hmmm... the spec still says:
* @throws IllegalArgumentException if <code>names</code> or
* <code>filters</code> is null, or if <code>names</code> contains
* a null element, or if the three arrays do not all have the same
* size.
```
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19253#discussion_r1603184648
