On Tue, 10 Sep 2024 13:06:25 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Remove very very old serialization compatibility logic from JMX.
>>
>> This relates to keeping the JDK's JMX implementation compatible with JMX
>> versions from when JMX was a separate component, before being integrated
>> into JDK 5. It should all be removed.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove a list level in Javadoc.
Changes requested by dfuchs (Reviewer).
src/java.management/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java
line 124:
> 122:
> 123: private static final long serialVersionUID =
> 6181543027787327345L;
> 124: private static final ObjectStreamField[] serialPersistentFields =
API doc coment for serial persistent fields should have been preserved.
Suggestion:
/**
* @serialField attrDescriptor Descriptor The {@link Descriptor}
* containing the metadata corresponding to this attribute
*/
private static final ObjectStreamField[] serialPersistentFields =
-------------
PR Review: https://git.openjdk.org/jdk/pull/20856#pullrequestreview-2292536179
PR Review Comment: https://git.openjdk.org/jdk/pull/20856#discussion_r1751974983
