On Wed, 24 Sep 2025 19:59:55 GMT, Alex Menkov <[email protected]> wrote:
>> The fix updates `jcmd
>> Thread.dump_to_file`/`HotSpotDiagnosticMXBean.dumpThreads` implementation to
>> report thread which owns parkBlocker.
>>
>> Testing: tier1..4,hs-tier5-svc
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> feedback
test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line 445:
> 443: assertNotNull(parkBlocker);
> 444:
> assertTrue(parkBlocker.contains("java.util.concurrent.locks.ReentrantLock"));
> 445:
Will you add 8365057 to the `@bug` at the top?
test/lib/jdk/test/lib/threaddump/ThreadDump.java line 300:
> 298:
> 299: /**
> 300: * Returns the owner of the parkBlocker if the parkBlocker is an
> AQS.
Can you change "AQS" to AbstractOwnableSynchronizer here? It could be changed
to AOS too but few will know what it means.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27457#discussion_r2377924570
PR Review Comment: https://git.openjdk.org/jdk/pull/27457#discussion_r2377928658
