On Sat, 22 Nov 2025 07:52:40 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename VM methods for endFirstTransition/startFinalTransition
>
> src/hotspot/share/runtime/javaThread.cpp line 1173:
>
>> 1171: bool JavaThread::java_suspend(bool register_vthread_SR) {
>> 1172: #if INCLUDE_JVMTI
>> 1173: // Suspending a JavaThread in VTMS transition or disabling VTMS
>> transitions can cause deadlocks.
>
> Q: I wonder if the `#if INCLUDE_JVMTI` and `#endif` can be removed here.
Yes, removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28361#discussion_r2561254972