The GitHub Actions job "Tests (AMD)" on 
airflow.git/narrow-team-namespace-refusal-to-plausible-team-names has succeeded.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
cfa6a6511634a76cdba716ef6b3f7d0fa593fa55 / Jarek Potiuk <[email protected]>
Refuse only ids whose leading segment could name a team

Refusing every id of the form `_<x>___<y>` was too broad. A team agnostic
secret whose id merely looks namespaced -- `_a___b`, `_ab___x` -- was refused
even though `a` and `ab` are too short to be team names, so no team namespace
can be spelled that way and the lookup was safe. That blocked a legitimate
lookup for no benefit.

Test the leading segment against the team name rule instead. Every id that does
spell a real team's namespace still has a valid team name in that position by
construction, so nothing reachable is let through, while ids that cannot name a
team resolve normally again. Every split is considered, since a team name may
itself contain the separator, and one plausible team name is enough to refuse.

This makes the guard depend on stored team names actually being valid, so
`teams sync` now enforces the same rule as `teams create`. It creates teams
from the dag bundle config and did not validate the names at all, which would
have left the guard's assumption unbacked -- an unvalidated short name such as
"a" would make the test miss and reopen the cross-team read.

Generated-by: Claude Opus 5 (1M context) following the guidelines at
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions

Report URL: https://github.com/apache/airflow/actions/runs/30677588077

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to