The GitHub Actions job "Tests (AMD)" on 
airflow.git/remove-dead-typeerror-handler-in-credentials-save has succeeded.
Run started by GitHub user rjgoyln (triggered by rjgoyln).

Head commit for run:
89ba99db3abd7c17c5e7e16de769c88358cee5f7 / rjgoyln <[email protected]>
Stop swallowing unexpected keyring errors when saving airflowctl credentials

The TypeError handler in Credentials.save() only produced a meaningful
error when api_token was None and client_kind was ClientKind.CLI at the
same time. No caller can satisfy both: the two save() call sites in
auth_command.py pass ClientKind.AUTH or leave client_kind at its default
of None, and each already guarantees a non-None token. The branch was
therefore unreachable, leaving the handler as an unconditional swallow
that let a failed credential save return as if it had succeeded.

Report URL: https://github.com/apache/airflow/actions/runs/30817381886

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to