The GitHub Actions job "Tests (AMD)" on airflow.git/backport-70893-v3-3-test 
has succeeded.
Run started by GitHub user vatsrahul1001 (triggered by vatsrahul1001).

Head commit for run:
87aa3bd3ad6ed61b1aaaf9ceb3c2b710d8f201bd / Jarek Potiuk <[email protected]>
Resolve the Dag's team when authorizing a Dag found by lookup (#70893)

* Resolve the Dag's team when authorizing a Dag found by lookup

Two authorization checks build DagDetails(id=dag_id) without team_name:
materialize_asset, where the Dag is resolved from the asset, and the
XCom-specific check in wait_dag_run_until_finished. Every other call site
passes the team, resolved with DagModel.get_team_name.

A team-aware auth manager distinguishes a team-scoped Dag from a global one by
that field, so omitting it asks about a differently-scoped resource than the
one being acted on. In wait_dag_run_until_finished the route dependency already
resolves the team for its RUN check, so the two checks in the same handler
disagreed.

Resolve the team at both sites, reusing the request session.

* Cover the XCom authorization check with a team-scoped Dag

The existing wait-endpoint test uses a Dag with no team, where the resolved and
unresolved forms are indistinguishable, so nothing caught the second check 
asking
about a differently-scoped resource than the route dependency did.

* Update 
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py

Co-authored-by: Amogh Desai <[email protected]>

* Update 
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py

Co-authored-by: Amogh Desai <[email protected]>

* Fix docstring indentation from the applied review suggestions

---------

Co-authored-by: Amogh Desai <[email protected]>
(cherry picked from commit f81459835adb111e57b2a87f586d856395660f8a)

Report URL: https://github.com/apache/airflow/actions/runs/30920766685

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to