The GitHub Actions job "Tests (AMD)" on airflow.git/variables-drop-unreachable-404-guard has failed. Run started by GitHub user ColtenOuO (triggered by ColtenOuO).
Head commit for run: e911207b39951610c6546fcadab27196f27f0763 / ColtenOuO <[email protected]> Remove the unreachable 404 from the create Variable endpoint The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. Report URL: https://github.com/apache/airflow/actions/runs/31116919802 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
