The GitHub Actions job "Tests" on 
airflow.git/issues/63408/improve-e2e-dag-audit-log-spec has succeeded.
Run started by GitHub user sjyangkevin (triggered by sjyangkevin).

Head commit for run:
7a46501f99652e4b243592ad09a40fb1b86c183b / Kevin Yang <[email protected]>
Fix filter input locator and stabilize dag audit log e2e tests

setFilterValue() previously used getByPlaceholder(filterLabel) to find the
filter input after selecting a filter from the menu. This never matched
because InputWithAddon renders the label as a visible <Text> sibling of the
<input>, not as a placeholder attribute. The filter configs (e.g. EVENT_TYPE,
DAG_ID) do not define a placeholder field, so filter.config.placeholder is
undefined and React omits the attribute from the DOM entirely.

The fix uses the text-matching approach already established in XComsPage:

  page.locator("div").filter({ hasText: `${filterLabel}:` 
}).locator("input").first()

Note: getByPlaceholder() could be restored once the relevant filter configs
in filterConfigs.tsx expose a placeholder value, or once InputWithAddon gains
an aria-label prop (enabling the preferred getByLabel() approach). Both
require a coordinated source change discussed with UI maintainers.

Additional stability improvements:
- Raise addFilter() menu visibility timeout 5s → 10s (CI headroom)
- Raise setFilterValue() input visibility timeout 5s → 10s (CI headroom)
- Raise dag-audit-log individual test timeout 60s → 120s; waitForTableLoad()
  can consume up to 60s internally, leaving no room for navigation + assertions
  under the old limit on loaded CI runners

Report URL: https://github.com/apache/airflow/actions/runs/23099591831

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to