The GitHub Actions job "Tests (AMD)" on 
airflow.git/fix/airflow-fail-in-retry-callback has succeeded.
Run started by GitHub user 1fanwang (triggered by 1fanwang).

Head commit for run:
8f538c86f3690a394a39f426b84512f851fb1238 / 1fanwang <[email protected]>
Address review: drop redundant test docstring, assert callback state transitions

- Drop the docstring on 
`test_airflow_fail_exception_in_on_retry_callback_fails_task`;
  the test name already describes the assertion, and the project style guide
  prefers no docstrings in tests that merely repeat the function name.
- Assert the recorded callback states directly
  (`retry_callback_calls == [UP_FOR_RETRY]`, `failure_callback_calls == 
[FAILED]`)
  instead of the call counts. Pins both the count AND the state at the moment
  each callback ran -- proving on_retry_callback fired while the task was
  UP_FOR_RETRY and on_failure_callback fired after AirflowFailException
  promoted it to FAILED.

Signed-off-by: 1fanwang <[email protected]>

Report URL: https://github.com/apache/airflow/actions/runs/25827330879

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to