The GitHub Actions job "Tests (AMD)" on airflow.git/refactor/go-sdk/coordinator-runtime has failed. Run started by GitHub user jason810496 (triggered by jason810496).
Head commit for run: 7446bb3315f53072bcab06c8bdb4435816d912bd / LIU ZHE YOU <[email protected]> self-review: Harden coordinator runtime against malformed inputs Six follow-up items from Copilot's review on #67154, all in the coordinator-protocol runtime introduced by this branch. Each is a small defensive change with no behavioural impact on the happy path: - frames.go: cap readFrame's payload allocation at 64 MiB. The 4-byte length prefix was trusted without bound, so a corrupted stream could request a multi-GB allocation before the read failed. 64 MiB is far above any realistic StartupDetails or XCom payload. - execution/server.go: dial the comm/logs sockets through a net.Dialer with a 30s timeout instead of net.Dial, so an unreachable supervisor fails fast rather than hanging the runtime. - task_runner.go: surface uuid.Parse errors on details.TI.ID. The previous code dropped the error and used the zero UUID, which would silently corrupt XCom pushes and heartbeats; we now log and return a failed TaskState. - messages.go: distinguish missing from present-but-malformed timestamps in decodeTIRunContext and decodeStartupDetails.start_date. Missing fields still leave nil/zero values; malformed values now return a decode error instead of being silently dropped. - bundlev1server/server.go: replace os.Exit(2) + flag.Usage() in the --comm/--logs misuse branch with a new ErrCoordinatorFlagsIncomplete sentinel. The library no longer terminates the process itself, which makes Serve testable and lets callers decide how to surface the error. The example bundle's main now log.Fatal's the result so the binary still exits non-zero on misuse. Tests added for the new error paths in frames_test.go and messages_test.go; existing tests continue to pass. Report URL: https://github.com/apache/airflow/actions/runs/26220682864 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
