The GitHub Actions job "Tests (AMD)" on airflow.git/backport-6ecae68-v3-2-test 
has succeeded.
Run started by GitHub user vatsrahul1001 (triggered by vatsrahul1001).

Head commit for run:
3deecf8fa4a88c8e6d1d3ae9386b556a88c00ae9 / Jarek Potiuk <[email protected]>
[v3-2-test] CI: fix milestone-tag-assistant race when labels change post-merge 
(#67337)

The `milestone-tag-assistant.yml` workflow snapshots PR labels at the
`get-pr-info` job (via `listPullRequestsAssociatedWithCommit`) and then
spends ~1.5 minutes installing Breeze and running `breeze ci
set-milestone`. If a maintainer adds and removes a backport label
inside that window, the action commits to the stale-snapshot decision
and sets the wrong milestone — see the incident on PR #67301 where a
backport label that lived for 49 seconds caused an Airflow-3.2.3
milestone to be set on a `main`-only documentation PR.

Re-read `issue.labels` from the freshly-fetched issue before computing
the milestone. If the labels changed since the snapshot:

- Honour any skip label that appeared after the snapshot.
- Re-run `_determine_milestone_version` with the current labels and
  use the fresh decision; if the decision flips to "no milestone",
  bail out before posting the comment.

Adds three regression tests covering the three race-window cases
(backport label removed, replaced, skip label added) and updates two
existing happy-path tests to populate `mock_issue.labels` so the
re-read sees the same labels as the snapshot.
(cherry picked from commit 6ecae6853e650fbcf8a67225eec8915eb91523f5)

Co-authored-by: Jarek Potiuk <[email protected]>

Report URL: https://github.com/apache/airflow/actions/runs/26400816500

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to