On 07/05/07, Stephen Colebourne <[EMAIL PROTECTED]> wrote: > Hi, > Yes, if you could commit those three classes that would be great. Even > better if they have test cases ;-)
Done ! Couple of remarks: * i had to add a dependenc to antlr for the Interval test to pass * i put my test model beans in a subpackage called "testmodel". I was tempted to move the existing ones there, or move mine back to the base package - the intention was to keep the packages cleanly separated between actual tests and dummy model beans. It should be consistent, though, so if anyone has an opinion, please voice it. > Once they are in, I think I should release the next version of > joda-time-hibernate. Great, thanks ! Cheers g > > Grégory Joseph wrote: > > Hi list, > > > > Wow. Time flew. Almost a year ago, I was proposing to contribute > > hibernate persistence support for Period and Duration. I'd expected > > some discussion at the time before actually commiting it, which > > apparently never happened, and since then I've moved on to other > > horizons (i.e am still a Joda Time supporter but no longer hibernate > > user). I'm busy right now trying to clean up my own pet project, > > starting by dusting it off. Obviously this has nothing to do with my > > project per se, so I'd love to delegate them elsewhere. > > If noone objects, I'll just go and commit my 3 classes ? > > > > Cheers > > > > greg > > > > On 26/07/06, Grégory Joseph <[EMAIL PROTECTED]> wrote: > >> Hi Stephen, > >> > >> Sounds nice - my sf username is gjoseph (just new - changing from an > >> old account) - thanks ! > >> > >> Is Mario still around? If so I guess we should have a quick discussion > >> about our abstract classes and the tests, to make them more complete > >> and consistent. > >> > >> Cheers, > >> greg > >> > >> On 25/07/06, Stephen Colebourne <[EMAIL PROTECTED]> wrote: > >>> Hi, > >>> I'd love to see these in Joda-Time-Hibernate. Would you like commit > >>> rights to make it happen? Since I don't use hibernate, your probably > >>> closer to being able to test and check this than I would (and you have > >>> the itch...). Just drop me your sf name. > >>> > >>> Stephen > >>> > >>> > >>> Grégory Joseph wrote: > >>>> Hi list, > >>>> > >>>> This thread goes a long time back in time, and I actually add these > >>>> custom types implemented a while ago too. I can't say they have been > >>>> used much, because my own project ended up not using Periods and > >>>> Durations - but they're there and unit tested (the tests don't > >>>> completely test how they are represented in the db - I was lazy but > >>>> could I could add that - but tests they can be written/retrieved). > >>>> The thing is, these currently reside in a sub project of my own > >>>> project, to which they're not related at all. And since I'm in the > >>>> process of trying to re-focus my own project and get rid of > >>>> unnecessary/unrelated stuff, I'd like to get this out of the way, and > >>>> possibly contribute it back to jodatime/hibernate. (It's actually used > >>>> by another of the module in berkano, but that one's already a > >>>> candidate for being moved out of the main project:)) > >>>> > >>>> The source code is browsable at > >>>> http://svn.berkano.codehaus.org/browse/berkano/berkano/trunk/berkano-tools/jodatime-hibernate > >>>> Please tell me what you think - I've added my own abstract "helper" > >>>> class, and maybe the current hibernate types could reuse it, or > >>>> vice-versa of course :) (I remember we had a quick discussion here > >>>> about whether or not to implement EnhancedUserType instead of the > >>>> simple UserType, and Mario wouldn't remember the reason ;)) Same goes > >>>> for tests. > >>>> I'd love to contribute these to jodatime, in a way or another. For one > >>>> thing it would make the jodatime-hibernate module slightly more > >>>> complete, and it definitely belongs there rather that in berkano > >>>> (which is supposedly a user management library meant for j2ee/webapps) > >>>> > >>>> Cheers, > >>>> > >>>> greg > >>>> > >>>> On 21/12/05, Stephen Colebourne <[EMAIL PROTECTED]> wrote: > >>>> > >>>>> Grégory Joseph wrote: > >>>>> > >>>>>> Any opinion re: the persistence of Periods ? > >>>>> I would just store them in the standard ISO format as returned by the > >>>>> toString() method. > >>>>> > >>>>> Stephen > >>>>> > >>>>> > >>>>> ------------------------------------------------------- > >>>>> This SF.net email is sponsored by: Splunk Inc. Do you grep through log > >>>>> files > >>>>> for problems? Stop! Download the new AJAX search engine that makes > >>>>> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > >>>>> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > >>>>> _______________________________________________ > >>>>> Joda-interest mailing list > >>>>> [email protected] > >>>>> https://lists.sourceforge.net/lists/listinfo/joda-interest > >>>>> > >>>> > >>>> ------------------------------------------------------------------------- > >>>> Take Surveys. Earn Cash. Influence the Future of IT > >>>> Join SourceForge.net's Techsay panel and you'll get the chance to share > >>>> your > >>>> opinions on IT & business topics through brief surveys -- and earn cash > >>>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > >>>> _______________________________________________ > >>>> Joda-interest mailing list > >>>> [email protected] > >>>> https://lists.sourceforge.net/lists/listinfo/joda-interest > >>>> > >>> ------------------------------------------------------------------------- > >>> Take Surveys. Earn Cash. Influence the Future of IT > >>> Join SourceForge.net's Techsay panel and you'll get the chance to share > >>> your > >>> opinions on IT & business topics through brief surveys -- and earn cash > >>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > >>> _______________________________________________ > >>> Joda-interest mailing list > >>> [email protected] > >>> https://lists.sourceforge.net/lists/listinfo/joda-interest > >>> > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > _______________________________________________ > > Joda-interest mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/joda-interest > > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Joda-interest mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/joda-interest > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Joda-interest mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/joda-interest
