Actually, I was a little quick on the draw there.  After looking again:

>
>> 1 - donative == false; should be donative = false;
>
>
Yes, obvious error.  Updating patch.


>
>> 2 - The trigger on the parent is done before triggering the onfoo
>> handler.
>
>
Yes, seems like it needs doing.  There is a question over what order the
handlers get called here though that I'd like to clarify.  Current order is:

1. Normal handlers
2. "extra" function (which Im not clear on the use cases of
3. Native functions

It seems to me, although Im not clear on what the extra function is for that
it should be this order with bubbling included:

1. Normal handlers
2. Native functions
3. Bubble
4. "extra" function

Is that correct?


>
>> 3 - Instead of the whole _preventDefault thing, just do donative =
>> false inside the preventDefault function.
>> 4 - Same could be done for stopPropagation, having a local var call
>> bubble. Shorter, and we don't pollute the object. This one's just
>> misc.
>
>
This doesn't work as the bubble is a string of calls to
jQuery.event.trigger.  If either function gets called and set the vars in
the closure the vars will be set in the closure belonging to the wrong
instance of the function call so we need to use properties of the event
object.

Thanks,

-- 
Dan Webb
http://www.danwebb.net

aim: danwrong123
skype: danwrong

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jQuery Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/jquery-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to