The patch looks good - my only concern is in adding properties to $.fx (since that's where current fx plugins go). I think I'm ok with this, I doubt there will ever be an "off" animation (famous last words).
--John On Tue, Oct 21, 2008 at 7:24 PM, Ariel Flesler <[EMAIL PROTECTED]> wrote: > > Anyone ? O_o > > -- > Ariel Flesler > http://flesler.blogspot.com/ > > On Oct 18, 9:45 pm, Ariel Flesler <[EMAIL PROTECTED]> wrote: >> Animations can now be synchronous. >> http://dev.jquery.com/ticket/3495 >> >> I tried the $.fx.sync option and it's like +15 bytes and works >> perfectly. >> I renamed 'sync' to 'off' to avoid using complicated terms (though >> it's used by $.ajax). >> >> This means that if you do: >> >> jQuery.fx.off = true; >> >> All animations become synchronic. >> >> http://dev.jquery.com/ticket/3496 >> >> Won't commit yet, in case someone wants to say something :D >> >> -- >> Ariel Fleslerhttp://flesler.blogspot.com/ >> >> On Oct 8, 8:07 pm, Ariel Flesler <[EMAIL PROTECTED]> wrote: >> >> > I think this is wrong. >> > What if I get into a page, while a have a lot of programs running on >> > my fast computer... >> > I get a cookie that says "you're slow", so I get to see mediocre >> > animations for good (until the cookie is cleaned) just because I had >> > some overhead once. >> >> > I think we could make a plugin that overwrites the animation system, >> > making it lite. Then if a dev is interested, the page can provide a >> > link that reads "low quality version" or something like that. This >> > does set a cookie and loads the plugin for successive page loads. >> >> > The "lite" version of animation could simply make any animation >> > synchronous (instantaneous). >> >> > Actually... now that I say this. We could have a boolean flag like : >> > $.fx.sync= true; >> > That makes all future animations have 0 speed AND we make 0 speed >> > animssync. This is simple, totally doable. >> > The dev is in charge of setting that flag when desired. >> >> > Cheers >> >> > -- >> > Ariel Fleslerhttp://flesler.blogspot.com/ >> >> > On Oct 8, 3:42 am, "markus.staab" <[EMAIL PROTECTED]> wrote: >> >> > > i think this would be a nice approach.. the result of this "benchmark" >> > > could be stored in a cookie and wouldn't have a big impact on every >> > > pageload.... >> >> > > On 7 Okt., 22:56, "Jörn Zaefferer" <[EMAIL PROTECTED]> >> > > wrote: >> >> > > > Maybe run an invisble but expensive animation and check how many steps >> > > > are actually rendered, eg. animate an element for 100px for 100ms and >> > > > check how often the step-callback is actually called for that >> > > > animation. Anything below a certain threshold is considered too slow. >> >> > > > Jörn >> >> > > > On Tue, Oct 7, 2008 at 8:07 PM, John Resig <[EMAIL PROTECTED]> wrote: >> >> > > > > How would you detect if someone is on a slower machine? (Just >> > > > > curious) >> >> > > > > But yes, it was discussed recently that passing in an animation speed >> > > > > of 0 might have that effect. Another good side effect is that >> > > > > animations can be disabled for accessibility reasons (e.g. people who >> > > > > have extreme motion sickness). >> >> > > > > --John >> >> > > > > On Tue, Oct 7, 2008 at 11:00 AM, Florin <[EMAIL PROTECTED]> wrote: >> >> > > > >> Hi, >> >> > > > >> Animations and special effects (like fadeIn/fadeOut) are very nice, >> > > > >> but on slower computers they don't look so good and are a serious >> > > > >> performance issue. >> >> > > > >> Would you consider an option to disable the animations? >> >> > > > >> For instance, any call to animate() would just set the corresponding >> > > > >> final CSS and call the callback, without animating through the >> > > > >> intermediate steps ? >> >> > > > >> Any workarounds which don't require changing the code a lot ? > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-dev@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
