The support test is checking whether the browser thinks a tabindex attribute exists, as opposed to tabIndex. I'll add a comment and upload a new patch.
Also, the code for getting the tabindex is based on information from a Fluid article which describes in detail why this needs to happen and what the results are in each browser if we don't use getAttributeNode. Should we put the URL of the article in a comment for reference if someone wants to know why that's being done? http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/ I'll run all the tests again and let you know if anything changed. On Jan 5, 9:05 am, "John Resig" <[email protected]> wrote: > This looks good to me! Just a quick question about the tabIndex > property that you're adding to .support. What exactly are you trying > to test with it? A one-line comment describing it and the the browsers > in which it passes/fails would be good - other than that it looks > great. > > Did any selector tests break when you added the new block of HTML to > the test page? Just double-check to make sure. > > --John > > On Sun, Jan 4, 2009 at 11:03 PM, Scott González > > <[email protected]> wrote: > > I just attached a patch for tickethttp://dev.jquery.com/ticket/3649to fix > > getting and setting tabindex in IE. I'm hoping the patch can be reviewed > > and committed for 1.3. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
