I'm not completely convinced that this should be "fixed". I don't think we've ever truly supported selectors on text nodes (they may have worked, but we certainly didn't support it).
--John On Mon, Jan 5, 2009 at 5:33 PM, Ariel Flesler <[email protected]> wrote: > > That's Sizzle's original code, I suppose the reason is it was > obviously independent from jQuery's code. > Will tell John about this, thanks. > > -- > Ariel Flesler > http://flesler.blogspot.com > > On Jan 5, 8:07 am, Balazs Endresz <[email protected]> wrote: >> There are a bunch of `nodeType === 1` checks in the selector engine, I >> guess that's the cause. >> >> OFF: >> I've just noticed that there are two ` instanceof Array` checks too. >> Why not use ...toString? >> >> On Jan 5, 7:52 am, MarionNewlevant <[email protected]> wrote: >> >> > This html: >> > <body> >> > <div id="demo">Lorem ipsum dolor sit amet.</div> >> > </body> >> >> > This jQuery: >> > $(document).ready(function(){ >> > alert($('#demo').contents().filter('[nodeType = 3]').length); >> > alert($('#demo').contents().filter('[nodeType=3]').length); >> >> > }); >> >> > both alerts are 1 in 1.2.6, 0 in 1.3_b1 >> >> > Thanks, Marion >> >> > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
