I just added this point to the release notes - thanks for bringing it up. Have you run across any other problems that we haven't mentioned? We definitely want to make sure that we cover them all.
Oh, and no problem - glad you're enjoying jQuery :) --John On Thu, Feb 12, 2009 at 9:53 AM, THD <[email protected]> wrote: > > OK, thanks. I already suspected this was deprecated, it was no elegant > solution by any means. At least there is a simple fix for old code. > > I noticed there are a lot of different little problems when upgrading > 1.2.6 to 1.3.1. It might be worth it to add a readme to the release > version of jQuery 1.3.x with a link to > http://docs.jquery.com/Release:jQuery_1.3#Changes > (I should have read this page first of course), or maybe even a more > extended 'changes' page with solutions for common problems. This might > save some people a lot of trouble. > > Oh, and by the way: Thanks for jQuery John! > > Regards, > THD > > > On 12 feb, 15:13, John Resig <[email protected]> wrote: >> This was intentionally removed. Including extra code for doing code >> evaluation was seriously affecting other environments like Adobe AIR >> and Caja. (Not to mention the fact that having those code strings was >> probably just a bad idea to begin with.) >> >> We deprecated that behavior a while back, actually, and just finally >> got around to removing it in 1.3. In this case the switch to using >> functions for the selector filters isn't that much harder. >> >> --John >> >> On Thu, Feb 12, 2009 at 8:46 AM, THD <[email protected]> wrote: >> >> > Custom expressions like the ones in jQMinMax fail with an error when >> > used in the selector. (jQMinMax is found here: >> >http://davecardwell.co.uk/javascript/jquery/plugins/jquery-minmax/) >> >> > All browsers fail with an error that 'filter is not a function' in the >> > line: >> > return filter( elem, i, match, array ); >> >> > Is the old method of adding a new expression as a string instead of a >> > function not valid anymore or was this method wrong from the start? >> >> > Old method: $.expr[':']['expression'] = expr; // this works in 1.2.6, >> > but fails in 1.3.1 >> > Simple fix: $.expr[':']['expression'] = function(a) { eval(expr); } >> >> > Maybe jQuery can check if the expression is a string and use the eval >> > to create a function, this way scripts like the old jQMinMax won't be >> > broken by upgrading to 1.3.x. >> >> > Regards, >> > THD >> >> > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
