Whoops... spoke to soon. The show method is throwing errors in IE 6. The main issue is that IE 6 doesn't like setting this[i].style.display to undefined. Second, it looks like the second for loop is sitting within the first for loop when I believe the intention was to have them separate, not nested. Resolved in R6215. Actually, is that second for loop in show really fixing anything? Typically we shouldn't need to set the display property again b/c we already set it once in the first for loop (line 28 of fx.js). The only reason we would set it again is if the element was still hidden. However, with the second for loop we are always resetting the display value even if we don't need to.
Looks like we just need to remove the second for loop in show and move the assignment of style.display back into the if block of the first for loop. However, I wanted to make sure I wasn't over looking something. -- Brandon Aaron On Mon, Feb 16, 2009 at 2:06 PM, Brandon Aaron <[email protected]>wrote: > No issues here. > -- > Brandon Aaron > > > On Mon, Feb 16, 2009 at 12:31 PM, John Resig <[email protected]> wrote: > >> >> Hey Everyone - >> >> Just finished up the last ticket for 1.3.2 and wanted to throw a copy >> out for people to try: >> http://code.jquery.com/nightlies/jquery-2009-02-16.js >> >> Please let me know if anything is breaking from 1.3.1 -> 1.3.2. >> >> There were some logic changes - specifically with cloning in IE (lots >> of bug fixes), how the selector engine, how :visible/:hidden work, >> .height()/.width(), and .ready() in IE - so watch those areas in >> particular. >> >> The current full ticket list can be found here: >> http://dev.jquery.com/report/33 >> >> Thanks! >> >> --John >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
