Filed and fixed: http://dev.jquery.com/ticket/4902 http://dev.jquery.com/changeset/6434
--John On Tue, Jul 14, 2009 at 7:01 PM, David Flanagan <da...@davidflanagan.com>wrote: > > If the argument to a wrap function is a string that contains text, it > doesn't do what I'd expect it to. > > For example: $("h1").wrap("<i>\u00a7</i>") > > I'd expect that to wrap all h1 elements in <i> tags, with a section sign > (\u00a7) before the h1. > > I think the following patch to wrapAll() fixes it. On the other hand, > it doesn't make this work: $("h1").wrap("<i>\u00a7<b></b></i>"), so > perhaps this is a documentation bug: maybe the docs just need to be more > explicit about the legal arguments to the wrap() methods. > > David > > Index: manipulation.js > =================================================================== > --- manipulation.js (revision 6415) > +++ manipulation.js (working copy) > @@ -28,7 +28,7 @@ > wrap.map(function(){ > var elem = this; > > - while ( elem.firstChild ) > + while ( elem.firstChild && > elem.firstChild.nodeType == 1) > elem = elem.firstChild; > > return elem; > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-dev@googlegroups.com To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---