conditional comments are not features detection. I would rather do something
like:
xhr: window.ActiveXObject ? function(){return new ActiveXObject
("Microsoft.XMLHTTP")} : function(){return new XMLHttpRequest}
but I guess it does not make sense since xhr performances will never be a
problem (we do not create ajax call in loops, for example, do we?)
Regards
On Thu, Aug 20, 2009 at 9:21 AM, DBJDBJ <[email protected]> wrote:
>
> in jQuery 1.3.2 (line 3382, or nearby ;o)
>
> This simple optimization can be applied :
>
> BEFORE:
>
> xhr: function() {
> return window.ActiveXObject ? new ActiveXObject
> ("Microsoft.XMLHTTP") : new XMLHttpRequest();
> },
>
> AFTER:
>
> xhr: function() { return new XMLHttpRequest(); },
> //@cc_on xhr: function() { new ActiveXObject("Microsoft.XMLHTTP") },
>
> IF (IE) is the host the second version overwrites the first.
> IF (! IE) the second version is hidden by the comment.
>
> Obviously this can be done elsewhere in jQuery, for (significant)
> optimizations...
>
> --DBJ
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"jQuery Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/jquery-dev?hl=en
-~----------~----~----~----~------~----~------~--~---