Commented on the changeset. --John
On Wed, Nov 25, 2009 at 4:47 PM, Robert Katić <robert.ka...@gmail.com> wrote: > Now that jQuery.makeArray(nodeList) is supported correctly, maybe it > is wanted to make that also for jQuery.each, jQuery.map and > jQuery.grep. > > There are mainly two reasons why I think it is worth of consideration: > > 1. $.each(nodeList) is already possible and I suppose that there are > individuals that are considering that action legal because NodeLists > are array like things too. Unfortunately it is not always true in IE > and Opera where length expando can be overwrited. > > 2. Using $.each, $.map and $.grep directly with NodeLists can be still > useful, not only for optimizing jQuery itself. > > I made a patch that would fix this > http://github.com/rkatic/jquery/commit/7203092c23d5ddb623495f9145d2dab3edf1c529 > > If this change is welcome, than I will open a ticket... > > -- > > You received this message because you are subscribed to the Google Groups > "jQuery Development" group. > To post to this group, send email to jquery-...@googlegroups.com. > To unsubscribe from this group, send email to > jquery-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/jquery-dev?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-...@googlegroups.com. To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en.
