I've already landed the changes discussed (tweaking the logic - I landed the wrong patch, missed the '!') and making sure that there's a try/catch.
http://github.com/jquery/jquery/commit/3f648c4e3abe236b8ec6a19822313be794e5a9df I tested in Firefox, IE 6 & 7 with ActiveX disabled. IE 6 just stops, but doesn't throw an exception, IE 7 runs all the tests (since it has an XMLHttpRequest implementation). --John On Tue, Jan 5, 2010 at 11:31 AM, Matt <m...@thekrusefamily.com> wrote: > On Jan 5, 10:04 am, John Resig <jere...@gmail.com> wrote: >> The current logic is imperfect (in that, theoretically, someone could >> be trying to use jQuery on a local file, in IE 7, with ActiveX >> disabled and it would error out) but for now that's something that I >> can live with. > > Why live with it? It fails in IE6 under the same conditions as well. > That, as far as I can tell, should be a jQuery-supported environment. > > It also fails under FF, local file because your logic is incorrect: > > return window.XMLHttpRequest && window.location.protocol !== "file:" > || window.ActiveXObject ? > new window.XMLHttpRequest() : > new window.ActiveXObject("Microsoft.XMLHTTP"); > > In FF: > return (true && false || false)? <ignored> : new window.ActiveXObject > ("Microsoft.XMLHTTP") > ERROR: > "window.ActiveXObject is not a constructor" > > Matt Kruse > > -- > You received this message because you are subscribed to the Google Groups > "jQuery Development" group. > To post to this group, send email to jquery-...@googlegroups.com. > To unsubscribe from this group, send email to > jquery-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/jquery-dev?hl=en. > > > >
-- You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-...@googlegroups.com. To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en.
