Good catch! Fixed:
http://github.com/jquery/jquery/commit/4397f0fd41064346bce16772eec78cd5d2a1682e

--John



On Wed, Jan 13, 2010 at 11:04 PM, Prestaul <matt.dun...@wallst.com> wrote:
> Solution looks like it is working, but you've left a reference to
> thisObject in events.js around line 765.  This is resulting in a
> window.thisObject showing up after using "bind" or "one".  Should be
> an easy fix.
>
> On Jan 3, 8:56 am, John Resig <jere...@gmail.com> wrote:
>> Oh, good point - I forgot that this was a more recent change. Still,
>> it'll be good to maintain the old API here.
>>
>> Alright, I'll try to land in the proxy() change later today then and
>> back out .bind( name, fn, scope ).
>>
>> --John
>>
>> 2010/1/3 Scott González <scott.gonza...@gmail.com>:
>>
>>
>>
>> > This actually doesn't work in 1.3.2. It just throws an error expecting
>> > the proxy to be a function, not an object.
>>
>> > On Dec 31 2009, 12:39 am, John Resig <jere...@gmail.com> wrote:
>> >> jQuery has already solved this problem internally using our
>> >> jQuery.event.proxy method - and, in fact, if I were to land a
>> >> jQuery.bind() it would end up using jQuery.event.proxy(). But if you
>> >> look at jQuery.event.proxy() you can see that, in reality, we could
>> >> just be using that method and skip this whole dance entirely. For
>> >> example (and this works today, in jQuery 1.3.2):
>>
>> >> function foo(){}
>> >> .bind( "click", jQuery.event.proxy( foo, someObject ) );
>> >> .unbind( "click", foo );
>>
>> > --
>>
>> > You received this message because you are subscribed to the Google Groups 
>> > "jQuery Development" group.
>> > To post to this group, send email to jquery-...@googlegroups.com.
>> > To unsubscribe from this group, send email to 
>> > jquery-dev+unsubscr...@googlegroups.com.
>> > For more options, visit this group 
>> > athttp://groups.google.com/group/jquery-dev?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "jQuery Development" group.
> To post to this group, send email to jquery-...@googlegroups.com.
> To unsubscribe from this group, send email to 
> jquery-dev+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/jquery-dev?hl=en.
>
>
>
>
-- 
You received this message because you are subscribed to the Google Groups 
"jQuery Development" group.
To post to this group, send email to jquery-...@googlegroups.com.
To unsubscribe from this group, send email to 
jquery-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/jquery-dev?hl=en.


Reply via email to