On 8/30/07, Matt Kruse <[EMAIL PROTECTED]> wrote: > In this case you are fixing a bug that happens to appear in one > browser, but why limit the fix to only that browser? What if another > browser based on Safari comes out but has a different user agent > string and isn't recognized by jQuery? Wouldn't you still want the bug > to be fixed? What harm would it cause to leave out the browser check?
I forgot to mention that the check against $.browser.safari is a little deceiving. We are actually checking against WebKit, which would also catch any browser based on Safrai ... like Shiira. It is a very sticky topic and one we all feel very passionate about. None and I mean _none_ of us like doing browser detection/sniffing. It if it is there, it has mostly likely be tested without it first and added only when absolutely necessary. Regarding this particular fix, I don't recall if it negatively affected another browser/engine. -- Brandon Aaron
